D26848: Don't assume the manager and menu have the same lifetime

[David Redondo]

davidre added inline comments.

INLINE COMMENTS

> kcolorschememanager.cpp:191
>      QActionGroup *group = new QActionGroup(menu);
> -    connect(group, &QActionGroup::triggered, this,  [this](QAction * action) {
> -        activateScheme(d->model->index(action->data().toInt()));
> +    connect(group, &QActionGroup::triggered, [] (QAction * action) {
> +        ::activateScheme(action->data().toString());

What is meant by "connecting to qApp"?  Just doing the scheme switching here? I wanted to avoid the duplication that's why I created the static helper method.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D26848

To: davidre, #frameworks
Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200123/d529671d/attachment-0001.html>