D26848: Don't assume the manager and menu have the same lifetime

Anthony Fieroni noreply at phabricator.kde.org
Thu Jan 23 12:30:22 GMT 2020


anthonyfieroni added inline comments.

INLINE COMMENTS

> kcolorschememanager.cpp:191
>      QActionGroup *group = new QActionGroup(menu);
> -    connect(group, &QActionGroup::triggered, this,  [this](QAction * action) {
> -        activateScheme(d->model->index(action->data().toInt()));
> +    connect(group, &QActionGroup::triggered, [] (QAction * action) {
> +        ::activateScheme(action->data().toString());

You can connect to `qApp`

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D26848

To: davidre, #frameworks
Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200123/73e31bd3/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list