D25015: Update breeze theme shadows

Noah Davis noreply at phabricator.kde.org
Sun Jan 19 04:22:23 GMT 2020


ndavis added a comment.


  I noticed a few things.
  
  ---
  
  The masks have a rather odd shape and it's not pixel aligned, which might mean something is wrong: 
  F7891523: Screenshot_20200118_225818.PNG <https://phabricator.kde.org/F7891523>
  It's different from master, which looks pretty normal: 
  F7891527: Screenshot_20200118_230209.PNG <https://phabricator.kde.org/F7891527>
  
  ---
  
  In the `panel-background` a `tooltip` SVGs the shadow was changed, but the tooltip was not. Keep in mind that 
  F7891542: Screenshot_20200118_231610.PNG <https://phabricator.kde.org/F7891542>
  
  ---
  
  I get the impression that these were changed with the node tool rather than creating the corners from rounded rectangles. I guess that works as long as all the svg corners are consistent with each other, but it's inconsistent with the QStyle and could still lead to visible pixel misalignment when the UI is scaled up.
  F7891536: Screenshot_20200118_230921.PNG <https://phabricator.kde.org/F7891536>
  
  ---
  
  Why is `widgets/background.svg` different from the other ones? Maybe there's a good reason, since it's also different in the master branch, but its very odd.
  F7891628: Screenshot_20200118_232026.PNG <https://phabricator.kde.org/F7891628>

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  bettershadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg, ngraham
Cc: mart, broulik, cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200119/4abdcba8/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list