D26758: [WIP] Fix the size and pixel alignment of checkboxes and radiobuttons

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  The checkboxes and radio buttons in plasmashell were signficantly different from checkboxes and radio buttons in the Breeze QStyle.
  
  - Plasmashell checkboxes and radio buttons were much larger.
    - 24x24 for checkboxes and 29x29 for radio buttons (Plasmashell) vs 16x16 (QStyle).
  - Pixel alignment was very poor.
    - Checkbox indicator was 14x14, stretched to 24x24.
    - Radio button background was 22x22 or 32x32, adjusted to 29x29.
    - Radio button indicator was 16x16, stretched to 29x29.
  - Style was different.
    - Checkbox indicators had sharper corners and less margin around the inner rectangle.
    - Radio buttons had a hardcoded dark gray circular frame and a shadow on the bottom of the inside of the frame.
    - Radio button indicators had less margin around the inner circle.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  checkbox-radiobutton (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26758

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/CheckIndicator.qml
  src/declarativeimports/plasmacomponents3/RadioButton.qml
  src/declarativeimports/plasmacomponents3/RadioIndicator.qml
  src/declarativeimports/plasmastyle/CheckBoxStyle.qml
  src/declarativeimports/plasmastyle/RadioButtonStyle.qml
  src/desktoptheme/breeze/widgets/actionbutton.svg
  src/desktoptheme/breeze/widgets/checkmarks.svg

To: ndavis, #plasma, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200119/eb0f7696/attachment-0001.html>