D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on network fs

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> broulik wrote in kfileitem.cpp:783
> > when a network mount is unresponsive
> 
> If I do a `QFileInfo` on an unresponsive mount it will still block. You already freeze before you even know it's a network mount.

Good point, indeed the current solution does not work.
We need an alternative to KMountPoint::findByPath to check the path without calling QFileInfo.

> dfaure wrote in kfileitem.cpp:787
> You're right, the issue on the FreeBSD jail is fstab, not mnttab. Ignore what I said.
> 
> I still don't really like the assumption "no mountpoint found for a given path => we're on android" in a comment. I bet there are other corner cases where this can happen. If you really want to find out you're on android, surely there's Q_OS_ANDROID. Or until we find out what those other corner cases are, the code can stay, but the comment should say "for instance" or "maybe", not "can only mean".

I did not mean to avoid android, just surfaced the comment in KMountPoint::currentMountPoints regarding its limitation to make it clear why we need an else block here in the first place.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26407

To: meven, #frameworks, ngraham, broulik, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200104/422117a1/attachment.html>