D26292: [KSambaShare] Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in ksambashare.cpp:259
> badPattern was a bad name? ;-)

!notToMatchRx.match() -> "not notToMatchRx" double negative, slightly weird/heavy on the ear.

!badPattern.match() -> "not badPattern" -> valid share name; there's method to my madne^Wlogic, I just need to figure it out... :)

REPOSITORY
  R241 KIO

BRANCH
  l-qregularexpression-ksambashare (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26292

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200101/f4c0e817/attachment-0001.html>