D26292: [KSambaShare] Port QRegExp to QRegularExpression

David Faure noreply at phabricator.kde.org
Wed Jan 1 18:16:51 GMT 2020


dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> ksambashare.cpp:259
>      // Samba forbidden chars
> -    const QRegExp notToMatchRx(QStringLiteral("[%<>*\?|/\\+=;:\",]"));
> -    return (notToMatchRx.indexIn(name) == -1);
> +    const QRegularExpression notToMatchRx(QStringLiteral("[%<>*\?|/+=;:\",]"));
> +    return !notToMatchRx.match(name).hasMatch();

badPattern was a bad name? ;-)

REPOSITORY
  R241 KIO

BRANCH
  l-qregularexpression-ksambashare (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26292

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200101/d7917eb7/attachment.html>


More information about the Kde-frameworks-devel mailing list