D27363: KHolidays: Convert license statements to SPDX expressions

[Andreas Cord-Landwehr]

cordlandwehr marked 3 inline comments as done.
cordlandwehr added a comment.


  Did additional code digging in the Plan repository and I think that all stated copyright claims are valid.

INLINE COMMENTS

> cgiboudeaux wrote in holidayparserdriverplan.cpp:6-13
> The original text lacks clarity. Are these file contributors or copyright holders? @winterz

the original code comes from Plan's holiday.c

- original author has obvious claim, since important code fragments remain
- additional code contributors are listed in original source for contribution specific functions each, thus have also a valid copyright claim

> cgiboudeaux wrote in holidayparserplan.ypp:3-10
> same question for this file

analyzed code history:

- original file comes from Plan's parser.y by Thomas Driemeyer
- IMO the changes for integrating into KOrganizer are above the limit of copyright, so I would (in case of doubt) prefer to state copyright explicitly
- the individual conversion commits are unfortunately buried deep in the disabled Reviewboard

> cordlandwehr wrote in holidayscannerplan.cpp:1297-1301
> @winterz same question here as above: are these people copyright holders or file contributors?

this copyright statement comes from the .lpp file; thus to be discussed in that statement

> holidayscannerplan.lpp:2
>  /*
> -    Original version from plan by Thomas Driemeyer <thomas at bitrot.de>
> +    Original version from plan:
> +        SPDX-FileCopyrightText: Thomas Driemeyer <thomas at bitrot.de>

analyzed the code history of this file:

- original copyright claim comes from Plan's parser.lex file
- the code was massively changed and rewritten, thus IMO all three additional claims to the original author are valid IMO.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D27363

To: cordlandwehr
Cc: cgiboudeaux, winterz, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200222/8945f755/attachment.html>