<table><tr><td style="">cordlandwehr marked 3 inline comments as done.<br />cordlandwehr added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27363">View Revision</a></tr></table><br /><div><div><p>Did additional code digging in the Plan repository and I think that all stated copyright claims are valid.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27363#inline-154522">View Inline</a><span style="color: #4b4d51; font-weight: bold;">cgiboudeaux</span> wrote in <span style="color: #4b4d51; font-weight: bold;">holidayparserdriverplan.cpp:6-13</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">The original text lacks clarity. Are these file contributors or copyright holders? <a href="https://phabricator.kde.org/p/winterz/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@winterz</a></p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">the original code comes from Plan's holiday.c</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">original author has obvious claim, since important code fragments remain</li>
<li class="remarkup-list-item">additional code contributors are listed in original source for contribution specific functions each, thus have also a valid copyright claim</li>
</ul></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27363#inline-154523">View Inline</a><span style="color: #4b4d51; font-weight: bold;">cgiboudeaux</span> wrote in <span style="color: #4b4d51; font-weight: bold;">holidayparserplan.ypp:3-10</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">same question for this file</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">analyzed code history:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">original file comes from Plan's parser.y by Thomas Driemeyer</li>
<li class="remarkup-list-item">IMO the changes for integrating into KOrganizer are above the limit of copyright, so I would (in case of doubt) prefer to state copyright explicitly</li>
<li class="remarkup-list-item">the individual conversion commits are unfortunately buried deep in the disabled Reviewboard</li>
</ul></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27363#inline-154779">View Inline</a><span style="color: #4b4d51; font-weight: bold;">cordlandwehr</span> wrote in <span style="color: #4b4d51; font-weight: bold;">holidayscannerplan.cpp:1297-1301</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;"><a href="https://phabricator.kde.org/p/winterz/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@winterz</a> same question here as above: are these people copyright holders or file contributors?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this copyright statement comes from the .lpp file; thus to be discussed in that statement</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27363#inline-155787">View Inline</a><span style="color: #4b4d51; font-weight: bold;">holidayscannerplan.lpp:2</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">/*
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> Original version from plan<span class="bright"> by Thomas Driemeyer <thomas@bitrot.de></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> Original version from plan<span class="bright">:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> SPDX-FileCopyrightText: Thomas Driemeyer <thomas@bitrot.de>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">analyzed the code history of this file:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">original copyright claim comes from Plan's parser.lex file</li>
<li class="remarkup-list-item">the code was massively changed and rewritten, thus IMO all three additional claims to the original author are valid IMO.</li>
</ul></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R175 KHolidays</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27363">https://phabricator.kde.org/D27363</a></div></div><br /><div><strong>To: </strong>cordlandwehr<br /><strong>Cc: </strong>cgiboudeaux, winterz, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns<br /></div>