D27460: fix layout size hints for button labels

David Edmundson noreply at phabricator.kde.org
Wed Feb 19 10:13:20 GMT 2020


davidedmundson added inline comments.

INLINE COMMENTS

> Button.qml:62
> +            Layout.minimumHeight: units.iconSizes.tiny
> +            Layout.maximumWidth: Math.min(parent.height, control.icon.width > 0 ? control.icon.width : units.iconSizes.small)
> +            Layout.maximumHeight: Math.min(parent.width, control.icon.height > 0 ? control.icon.height : units.iconSizes.small)

I don't understand this part about constraining the width to the parent height  (for all 3)

If I remove it all the tests still pass.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27460

To: mart, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200219/4fce4a3b/attachment.html>


More information about the Kde-frameworks-devel mailing list