D27460: fix layout size hints for button labels

[Marco Martin]

mart marked an inline comment as done.
mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in button3.qml:90
> You didn't even run this :(
> 
> 1. icon.name not icon.source
> 2. now the comment next to it is wrong
> 3. there's a binding loop
> 
> 4. if I make a test without any text, which is what the thing you're supposedly fixing was doing, I don't get an icon

sorry,
tested, fixed the problem and added new tests

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27460

To: mart, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200219/3b7b2be6/attachment.html>