D23842: [KCompletion] Port away from deprecated methods in Qt 5.14

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Mon Dec 21 15:47:38 GMT 2020


kossebau added inline comments.

INLINE COMMENTS

> kcombobox.cpp:363
> +        connect(d->klineEdit, &KLineEdit::completionBoxActivated,
> +                this, QOverload<const QString&>::of(&QComboBox::textActivated));
> +#endif

Why the `QOverload<const QString&>::of()` with `&QComboBox::textActivated`? Accidental copy&paste?
After all the purpose of the new signals is to get rid of the overloading, no?

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D23842

To: dfaure, cfeck, dhaumann, aacid, vkrause
Cc: kossebau, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20201221/3602627f/attachment.htm>


More information about the Kde-frameworks-devel mailing list