<table><tr><td style="">kossebau added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23842">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23842#inline-172433">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kcombobox.cpp:363</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">connect</span><span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">klineEdit</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">KLineEdit</span><span style="color: #aa2211">::</span><span class="n">completionBoxActivated</span><span class="p">,</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">QOverload</span><span style="color: #aa2211"><</span><span style="color: #aa4000">const</span> <span class="n">QString</span><span style="color: #aa2211">&>::</span><span class="n">of</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">QComboBox</span><span style="color: #aa2211">::</span><span class="n">textActivated</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">#endif</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why the <tt style="background: #ebebeb; font-size: 13px;">QOverload<const QString&>::of()</tt> with <tt style="background: #ebebeb; font-size: 13px;">&QComboBox::textActivated</tt>? Accidental copy&paste?<br />
After all the purpose of the new signals is to get rid of the overloading, no?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R284 KCompletion</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23842">https://phabricator.kde.org/D23842</a></div></div><br /><div><strong>To: </strong>dfaure, cfeck, dhaumann, aacid, vkrause<br /><strong>Cc: </strong>kossebau, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns<br /></div>