D29101: WIP BUG: 420312 Fix file path and process call

[Alexander Lohnau]

alex created this revision.
alex added reviewers: KNewStuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
alex requested review of this revision.

REVISION SUMMARY
  The bug was caused by two issues: The file path that was stored was wrong, for example:
  Old paths:
  /home/user/.local/share/servicemenu-download//rootactions_servicemenu_2.9.1.tar.gz
  New paths:
  /home/user/.local/share/servicemenu-download/iso_mounter_unmounter.desktop
  
  Additionally the overload for the process call always fails, for example:
  `qWarning() << QProcess::execute("echo \"Hello there!\""); // Works
  qWarning() << QProcess::execute("echo",{"\"Hello there!\""}); // Works
  qWarning() << QProcess::execute("echo \"Hello there!\"",{}); // Fails, returns -2`/
  
  As in https://phabricator.kde.org/R304:9322aaf990dd0500a81914d9f69183293cc08a58 explained 
  QProcess::execute(QString) is deprecated, should KShell be used?
  And should this be split up, because it is unrelated to the other change?

TEST PLAN
  Try out what was described in bug report

REPOSITORY
  R304 KNewStuff

BRANCH
  bugfix_uninstall (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29101

AFFECTED FILES
  src/core/installation.cpp

To: alex, #knewstuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200422/a91f9568/attachment.html>