<table><tr><td style="">alex created this revision.<br />alex added reviewers: KNewStuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent.<br />Herald added a project: Frameworks.<br />Herald added a subscriber: kde-frameworks-devel.<br />alex requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29101">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The bug was caused by two issues: The file path that was stored was wrong, for example:<br />
Old paths:<br />
/home/user/.local/share/servicemenu-download//rootactions_servicemenu_2.9.1.tar.gz<br />
New paths:<br />
/home/user/.local/share/servicemenu-download/iso_mounter_unmounter.desktop</p>
<p>Additionally the overload for the process call always fails, for example:<br />
`qWarning() << QProcess::execute("echo \"Hello there!\""); <em> Works<br />
qWarning() << QProcess::execute("echo",{"\"Hello there!\""}); </em> Works<br />
qWarning() << QProcess::execute("echo \"Hello there!\"",{}); // Fails, returns -2`/</p>
<p>As in <a href="https://phabricator.kde.org/R304:9322aaf990dd0500a81914d9f69183293cc08a58" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/R304:9322aaf990dd0500a81914d9f69183293cc08a58</a> explained <br />
QProcess::execute(QString) is deprecated, should KShell be used?<br />
And should this be split up, because it is unrelated to the other change?</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Try out what was described in bug report</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R304 KNewStuff</div></div></div><br /><div><strong>BRANCH</strong><div><div>bugfix_uninstall (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29101">https://phabricator.kde.org/D29101</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/core/installation.cpp</div></div></div><br /><div><strong>To: </strong>alex, KNewStuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns<br /></div>