D29061: [KCharSelect] Minor code optimisation
    David Faure 
    noreply at phabricator.kde.org
       
    Wed Apr 22 14:16:31 BST 2020
    
    
  
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kcharselectdata.cpp:870
> +        const QRegularExpressionMatch match = hexExp.match(s);
> +        const QString cap = match.captured(1);
>          if (match.hasMatch()) {
Shouldn't this be moved to inside the `if (match.hasMatch())` check?
REPOSITORY
  R236 KWidgetsAddons
REVISION DETAIL
  https://phabricator.kde.org/D29061
To: ahmadsamir, #frameworks, cfeck, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200422/d747eb3c/attachment-0001.html>
    
    
More information about the Kde-frameworks-devel
mailing list