D29061: [KCharSelect] Minor code optimisation

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, cfeck, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  - Replace one last foreach with range-for, and set -DQT_NO_FOREACH
  - More const and static where appropriate
  - If a capture group is not used with QRegularExpression, better make it a clustering/non-capturing group, less book keeping on PCRE side

TEST PLAN
  make && ctest and a quick search in kcharselecttest still works.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-general-code-opti (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29061

AFFECTED FILES
  CMakeLists.txt
  src/kcharselectdata.cpp

To: ahmadsamir, #frameworks, cfeck, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200421/354b01f8/attachment.html>