D28862: [Extractor] Remove IdleStateMonitor wrapper class

Kai Uwe Broulik noreply at phabricator.kde.org
Thu Apr 16 07:47:01 BST 2020


broulik added a comment.


  It used to be 2 minutes, now it's 1?

INLINE COMMENTS

> app.cpp:59
> +    static int s_idleTimeout = 1000 * 60; // 1 min
> +    m_idleTime = KIdleTime::instance();
> +    m_idleTime->addIdleTimeout(s_idleTimeout);

Why the member variable? It's a singleton after all

> app.cpp:63
> +        qCInfo(BALOO) << "Busy, paced indexing";
> +        m_isBusy = true; });
> +    connect(m_idleTime, QOverload<int>::of(&KIdleTime::timeoutReached), this, [this] (int /*identifier*/) {

Coding style

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28862

To: bruns, #baloo, ngraham
Cc: broulik, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200416/41e1107d/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list