<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28862">View Revision</a></tr></table><br /><div><div><p>It used to be 2 minutes, now it's 1?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28862#inline-164664">View Inline</a><span style="color: #4b4d51; font-weight: bold;">app.cpp:59</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">static</span> <span style="color: #aa4000">int</span> <span class="n">s_idleTimeout</span> <span style="color: #aa2211">=</span> <span style="color: #601200">1000</span> <span style="color: #aa2211">*</span> <span style="color: #601200">60</span><span class="p">;</span> <span style="color: #74777d">// 1 min</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">m_idleTime</span> <span style="color: #aa2211">=</span> <span class="n">KIdleTime</span><span style="color: #aa2211">::</span><span class="n">instance</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">m_idleTime</span><span style="color: #aa2211">-></span><span class="n">addIdleTimeout</span><span class="p">(</span><span class="n">s_idleTimeout</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why the member variable? It's a singleton after all</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28862#inline-164665">View Inline</a><span style="color: #4b4d51; font-weight: bold;">app.cpp:63</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">qCInfo</span><span class="p">(</span><span class="n">BALOO</span><span class="p">)</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"Busy, paced indexing"</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">m_isBusy</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">true</span><span class="p">;</span> <span class="p">});</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">connect</span><span class="p">(</span><span class="n">m_idleTime</span><span class="p">,</span> <span class="n">QOverload</span><span style="color: #aa2211"><</span><span style="color: #aa4000">int</span><span style="color: #aa2211">>::</span><span class="n">of</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">KIdleTime</span><span style="color: #aa2211">::</span><span class="n">timeoutReached</span><span class="p">),</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="p">[</span><span style="color: #aa4000">this</span><span class="p">]</span> <span class="p">(</span><span style="color: #aa4000">int</span> <span style="color: #74777d">/*identifier*/</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Coding style</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R293 Baloo</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28862">https://phabricator.kde.org/D28862</a></div></div><br /><div><strong>To: </strong>bruns, Baloo, ngraham<br /><strong>Cc: </strong>broulik, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams<br /></div>