D28682: rename and export done signal in filecontentindexer

[Stefan Brüns]

bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> filecontentindexer.cpp:111
>                  [this, elapsed, batchSize] { newBatchTime(elapsed, batchSize); },
>                  Qt::QueuedConnection);
>          }

Sorry, seems I got a little bit confused, the `commitedBatch` has to go here.

And when I look at it, you can piggy-back on `newBatchTime`, which is emitted on each batch. For your use case, just ignore the values.

So new proposal, rename `newBatchTime(elapsed, batchSize)` to `committedBatch(elapsed, batchSize)` and export it. Keep `done` as is.

> filecontentindexer.cpp:114
>      }
> -    QMetaObject::invokeMethod(this, &FileContentIndexer::done, Qt::QueuedConnection);
> +    QMetaObject::invokeMethod(this, &FileContentIndexer::committedBatch, Qt::QueuedConnection);
>  }

This has to stay as is, as it means **everything**done

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28682

To: astippich, #baloo, bruns
Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200410/b4fc2b74/attachment.html>