<table><tr><td style="">bruns requested changes to this revision.<br />bruns added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28682">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28682#inline-163600">View Inline</a><span style="color: #4b4d51; font-weight: bold;">filecontentindexer.cpp:111</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">                <span class="p">[</span><span style="color: #aa4000">this</span><span class="p">,</span> <span class="n">elapsed</span><span class="p">,</span> <span class="n">batchSize</span><span class="p">]</span> <span class="p">{</span> <span class="n">newBatchTime</span><span class="p">(</span><span class="n">elapsed</span><span class="p">,</span> <span class="n">batchSize</span><span class="p">);</span> <span class="p">},</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">QueuedConnection</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Sorry, seems I got a little bit confused, the <tt style="background: #ebebeb; font-size: 13px;">commitedBatch</tt> has to go here.</p>

<p style="padding: 0; margin: 8px;">And when I look at it, you can piggy-back on <tt style="background: #ebebeb; font-size: 13px;">newBatchTime</tt>, which is emitted on each batch. For your use case, just ignore the values.</p>

<p style="padding: 0; margin: 8px;">So new proposal, rename <tt style="background: #ebebeb; font-size: 13px;">newBatchTime(elapsed, batchSize)</tt> to <tt style="background: #ebebeb; font-size: 13px;">committedBatch(elapsed, batchSize)</tt> and export it. Keep <tt style="background: #ebebeb; font-size: 13px;">done</tt> as is.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28682#inline-163601">View Inline</a><span style="color: #4b4d51; font-weight: bold;">filecontentindexer.cpp:114</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">QMetaObject</span><span style="color: #aa2211">::</span><span class="n">invokeMethod</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">FileContentIndexer</span><span style="color: #aa2211">::<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">done</span></span><span class="p">,</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">QueuedConnection</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QMetaObject</span><span style="color: #aa2211">::</span><span class="n">invokeMethod</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">FileContentIndexer</span><span style="color: #aa2211">::<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">committedBatch</span></span><span class="p">,</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">QueuedConnection</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This has to stay as is, as it means <strong>everything</strong>done</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R293 Baloo</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28682">https://phabricator.kde.org/D28682</a></div></div><br /><div><strong>To: </strong>astippich, Baloo, bruns<br /><strong>Cc: </strong>mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams<br /></div>