D28669: make CopyJob non-recursive

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in copyjob.cpp:814
> > Which threads? There are no threads involved here.
> 
> Yes, i'm afraid of loop that can block the event queue, !isKilled will not work in single thread environment.

Right. If this loop can really block the main thread for a substantial amount of time, then it should have a condition like "after 100 symlinks, schedule coming back here (e.g. QTimer singleshot) and `return;` for now".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28669

To: McPain, #frameworks, dfaure, meven, ahmadsamir
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200409/e980a0f3/attachment.html>