D28669: make CopyJob non-recursive

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> dfaure wrote in copyjob.cpp:814
> Which threads? There are no threads involved here.
> 
> There is no need to handling killing here. It wasn't any different in the orig code with the recursion.
> As soon as we find actual work to do, we'll go and launch a subjob, at which point we go back to the event loop and can handle being killed.

> Which threads? There are no threads involved here.

Yes, i'm afraid of loop that can block the event queue, !isKilled will not work in single thread environment.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28669

To: McPain, #frameworks, dfaure, meven, ahmadsamir
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200409/46066006/attachment.html>