D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

[Méven Car]

meven requested changes to this revision.
meven added a comment.
This revision now requires changes to proceed.


  I just want to keep as much checks as possible

INLINE COMMENTS

> jobtest.cpp:1524
> +    QVERIFY(entry.contains(KIO::UDSEntry::UDS_DEVICE_ID));
> +    QVERIFY(entry.contains(KIO::UDSEntry::UDS_INODE));
> +

add `QCOMPARE(entry.count(), 2);`

> jobtest.cpp:1535
> +    QVERIFY(otherEntry.contains(KIO::UDSEntry::UDS_DEVICE_ID));
> +    QVERIFY(otherEntry.contains(KIO::UDSEntry::UDS_INODE));
> +

add `QCOMPARE(otherEntry.count(), 2);`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28478

To: ahmadsamir, #frameworks, dfaure, meven, bruns
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200404/13ed6ceb/attachment.html>