D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

[Ahmad Samir]

ahmadsamir marked 4 inline comments as done.
ahmadsamir added inline comments.

INLINE COMMENTS

> meven wrote in jobtest.cpp:1530
> If you want to avoid doing this you can remove fields asked from statDetails `KIO::StatBasic | KIO::StatUser | KIO::StatInode` for instance.
> And have a more focused test.

Good point, I slimmed it down to just KIO::StatInode. (Maybe that's too thin?).

> meven wrote in jobtest.cpp:1568
> You can have an else with just ` QCOMPARE(device, otherDevice);` and move most of the  code inside of `if (!otherTmpDirIsOnSamePartition())` outside of the if branch.

I moved the condition to the top, if we can't find two partitions on the system, bail out early.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28478

To: ahmadsamir, #frameworks, dfaure, meven, bruns
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200402/3f192391/attachment.html>