D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  KProcessRunner::KProcessRunner(QString cmd) calls KProcess::setShellCommand(cmd) which ... has two modes. Either KShell::splitArgs()[0] finds an executable that exists (checking that there is no "&&" or "||" or ";" in the command) in which case it uses the splitted args, and no /bin/sh is involved, *or* it passes the whole command as is to "sh -c", as a single argument. That first optimization aside, it is logical for setShellCommand to take a single string. So It's logical to me that KProcessRunner takes a single string, and that you join the stringlist in CommandLauncherJob.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28515

To: broulik, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200402/f96e1c6f/attachment-0001.html>