D28515: [CommandLauncherJob] Add constructor taking an executable and argument list

Kai Uwe Broulik noreply at phabricator.kde.org
Thu Apr 2 14:17:38 BST 2020


broulik created this revision.
broulik added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  More convenient than having to construct a proper escaped commandline.

TEST PLAN
  - Ported the runners in D28512 <https://phabricator.kde.org/D28512> to use it, had something with a space properly escaped
  
  Somehow this looks a bit wrong to me, i.e. shouldnt we have some args in kprocessrunner, too, or does it also just pass that command along verbatim?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28515

AFFECTED FILES
  src/gui/commandlauncherjob.cpp
  src/gui/commandlauncherjob.h

To: broulik, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200402/50ddcf76/attachment.html>


More information about the Kde-frameworks-devel mailing list