D24014: [KWayland] Port away from deprecated API in Qt 5.14

[David Faure]

dfaure marked 3 inline comments as done.
dfaure added inline comments.

INLINE COMMENTS

> zzag wrote in test_wayland_surface.cpp:396
> I know it's unrelated, but erasing smart pointer types perhaps is not the greatest idea. Could you please use concrete type instead of auto while you're on this?

The "Almost Always Auto" crowd would disagree with you, but sure, your choice. Done.

> zzag wrote in region.cpp:61
> Heh, you could make it a bit simpler:
> 
>   for (const QRect &rect : region) {
>       ...
>   }

Heh indeed. I looked at the API, saw begin/end, used begin/end.... I forgot that this means range-for is available too :)

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24014

To: dfaure, davidedmundson, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190917/a3e1ef9f/attachment.html>