D24014: [KWayland] Port away from deprecated API in Qt 5.14

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> test_wayland_surface.cpp:396
>  
> -    wl_buffer *blackBuffer = *(m_shm->createBuffer(black).data());
> -    auto redBuffer = m_shm->createBuffer(red);
> +    auto blackBufferPtr = m_shm->createBuffer(black).toStrongRef();
> +    QVERIFY(blackBufferPtr);

I know it's unrelated, but erasing smart pointer types perhaps is not the greatest idea. Could you please use concrete type instead of auto while you're on this?

> region.cpp:61
>  {
> -    for (const auto &rect : region.rects()) {
> -        installRegion(rect);
> +    for (auto it = region.begin(); it != region.end(); ++it) {
> +        installRegion(*it);

Heh, you could make it a bit simpler:

  for (const QRect &rect : region) {
      ...
  }

> surface_interface_p.h:26-27
>  // Qt
>  #include <QVector>
> +#include <QHash>
>  // Wayland

Keep includes sorted please.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24014

To: dfaure, davidedmundson, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190917/06e095cf/attachment-0001.html>