D23915: Add some docstrings

Vlad Zahorodnii noreply at phabricator.kde.org
Fri Sep 13 09:31:33 BST 2019


zzag added inline comments.

INLINE COMMENTS

> dpms.h:44
>   *
> + * Display Power Management Signaling allows power management for monitors.
> + *

Not sure that this is valid documentation for org_kde_kwin_dpms_manager because it's nothing more but a factory.

> dpms_interface.h:38-41
> + * Display Power Management Signaling allows power management for monitors.
> + * A DpmsManagerInterface allows a client to query the DPMS state
> + * on a given OutputInterface and request changes to it.
> + * The code interaction happens only via the OutputInterface.

While it's sort of true, I don't think it's valid description. The line above precisely describes what DpmsManagerInterface is.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23915

To: gladhorn, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190913/2bb6df67/attachment.html>


More information about the Kde-frameworks-devel mailing list