D23713: strongswan support for custom proposals

[Pino Toscano]

pino added inline comments.

INLINE COMMENTS

> strongswanprop.ui:291
> +        <property name="title">
> +         <string>Cipher proposals</string>
> +        </property>

nitpick: "Cipher Proposals"

> strongswanprop.ui:295-299
> +          <widget class="QCheckBox" name="proposal">
> +           <property name="text">
> +            <string>Enable custom proposals</string>
> +           </property>
> +          </widget>

maybe use the checkable property of QGroupBox instead?

> strongswanwidget.cpp:155-156
> +    data.insert(NM_STRONGSWAN_PROPOSAL, d->ui.proposal->isChecked() ? "yes" : "no");
> +    data.insert(NM_STRONGSWAN_IKE, d->ui.ike->text());
> +    data.insert(NM_STRONGSWAN_ESP, d->ui.esp->text());
>  

should these be set only when the custom proposals are accepted?

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D23713

To: rrichmond, fvogt, jgrulich
Cc: pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190904/8de5f8b0/attachment-0001.html>