D25067: Fix the header layouts for EntryDetails and Page components

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Close, but not quite:
  
  F7695250: Screenshot_20191030_095130.png <https://phabricator.kde.org/F7695250>
  
  F7695252: Screenshot_20191030_095200.png <https://phabricator.kde.org/F7695252>

INLINE COMMENTS

> EntryDetails.qml:95
>      titleDelegate: QtLayouts.RowLayout {
> +        QtLayouts.Layout.fillWidth: true
>          implicitHeight: title.height

I don't think this works, since it's not inside another layout. Instead maybe `anchors.fill: parent` would work better?

> Page.qml:98
>      titleDelegate: QtLayouts.RowLayout {
> +        QtLayouts.Layout.fillWidth: true
>          Kirigami.Heading {

ditto

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25067

To: leinir, ngraham, #knewstuff, #frameworks, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191030/39493642/attachment.html>