D25059: KPluginSelector: use new KAboutPluginDialog

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in kpluginselector.cpp:799-803
> Can you guard for nullptr?

The pluginEntry? That would be inconsistent with the rest of the code here, which does no such checks.
We should be relatively safe here, as the slot should be only triggered if the "About" button was clicked, in which case the button has the focus, and such will focusedIndex() deliver a valid index.

So IMHO this code is working in promised conditions, if they are not met, something else is principally broken.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D25059

To: kossebau, #frameworks, dfaure, apol
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191030/d6ac8c62/attachment-0001.html>