D25059: KPluginSelector: use new KAboutPluginDialog

Anthony Fieroni noreply at phabricator.kde.org
Wed Oct 30 05:37:31 GMT 2019


anthonyfieroni added inline comments.

INLINE COMMENTS

> kpluginselector.cpp:799-803
> +    PluginEntry *pluginEntry = model->data(index, PluginEntryRole).value<PluginEntry *>();
> +    KPluginMetaData pluginMetaData = pluginEntry->pluginInfo.toMetaData();
> +
> +    KAboutPluginDialog aboutPlugin(pluginMetaData, itemView());
>      aboutPlugin.exec();

Can you guard for nullptr?

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D25059

To: kossebau, #frameworks, dfaure, apol
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191030/d791df2e/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list