D25071: Have KCModuleProxy take care of the defaulted state
Kevin Ottens
noreply at phabricator.kde.org
Wed Oct 30 12:29:49 GMT 2019
ervin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in kcmoduleproxy.cpp:196-197
> Why emit changed?
>
> Given KCModuleProxy mirrors KCModule API I would have expected a defaulted signal to match?
Because all the consumers I found surprisingly don't care about the distinction or the value of that bool. Also it would have led to more intrusive changes in said consumers. I admit I was surprised about that.
REPOSITORY
R295 KCMUtils
REVISION DETAIL
https://phabricator.kde.org/D25071
To: ervin, #plasma, #frameworks, mart, davidedmundson, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191030/7e3e18f1/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list