D25071: Have KCModuleProxy take care of the defaulted state

David Edmundson noreply at phabricator.kde.org
Wed Oct 30 12:21:57 GMT 2019


davidedmundson added inline comments.

INLINE COMMENTS

> kcmoduleproxy.cpp:196-197
> +    defaulted = d;
> +    emit q->changed(changed);
> +    emit q->changed(q);
> +}

Why emit changed?

Given KCModuleProxy mirrors KCModule API I would have expected a defaulted signal to match?

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D25071

To: ervin, #plasma, #frameworks, mart, davidedmundson, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191030/1f9168b6/attachment.html>


More information about the Kde-frameworks-devel mailing list