D24884: I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Mon Oct 28 18:46:11 GMT 2019
kossebau added a comment.
As said, I do not think this would be "better" code. And it's violating a bit the goal of zero cost abstractions, given this adds runtime need which could be avoided compared to the old code.
When using the I18N_NOOP, one has to know what you do and when you later on pass data pointers instead of literals to i18n calls. Thinking people who do that are in general challenged to ensure the proper context call is still used might be challenged in other places before IMHO.
And no, I do not want to do hacks in my own code, that proposal will be ignored. Let's have KI18n provide a nice API for developers, and not get in their way in some halfhearted way to be foolproof.
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D24884
To: mlaurent, dfaure, ilic
Cc: kossebau, aacid, vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191028/875bde2e/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list