D24979: KRunner: port away from deprecated KF5 API

David Faure noreply at phabricator.kde.org
Sun Oct 27 08:57:44 GMT 2019


dfaure created this revision.
dfaure added reviewers: kossebau, mart, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  Plasma::Package has been deprecated since 5.28, but it's used
  in the public API for AbstractRunner.
  
  Removed the underlying member variable which is never set
  (since apol's commit 8d77a33b6eae26 <https://phabricator.kde.org/R308:8d77a33b6eae263a49889c709590ea3ff569f2cf>).
  
  Once krunner is ported to the new deprecation macros, I guess
  the package() method will need something like
  
    #if KRUNNER_ENABLE_DEPRECATED_SINCE(5, 28)
  
  Technically the method wasn't marked as deprecated between 5.28 and 5.64
  but the class it returned, was, so that's pretty much the same.

TEST PLAN
  Builds

REPOSITORY
  R308 KRunner

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24979

AFFECTED FILES
  CMakeLists.txt
  src/abstractrunner.cpp
  src/abstractrunner.h
  src/abstractrunner_p.h

To: dfaure, kossebau, mart, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191027/31cd0e92/attachment.html>


More information about the Kde-frameworks-devel mailing list