<table><tr><td style="">dfaure created this revision.<br />dfaure added reviewers: kossebau, mart, apol.<br />Herald added a project: Frameworks.<br />Herald added a subscriber: kde-frameworks-devel.<br />dfaure requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24979">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Plasma::Package has been deprecated since 5.28, but it's used<br />
in the public API for AbstractRunner.</p>
<p>Removed the underlying member variable which is never set<br />
(since apol's commit <a href="https://phabricator.kde.org/R308:8d77a33b6eae263a49889c709590ea3ff569f2cf" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">8d77a33b6eae26</a>).</p>
<p>Once krunner is ported to the new deprecation macros, I guess<br />
the package() method will need something like</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">#if KRUNNER_ENABLE_DEPRECATED_SINCE(5, 28)</pre></div>
<p>Technically the method wasn't marked as deprecated between 5.28 and 5.64<br />
but the class it returned, was, so that's pretty much the same.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Builds</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R308 KRunner</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24979">https://phabricator.kde.org/D24979</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />
src/abstractrunner.cpp<br />
src/abstractrunner.h<br />
src/abstractrunner_p.h</div></div></div><br /><div><strong>To: </strong>dfaure, kossebau, mart, apol<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>