D24970: Port away from I18N_NOOP2 and KLocalizedString::insertQtDomain

[David Faure]

dfaure created this revision.
dfaure added reviewers: aacid, ilic.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  - Remove duplication of the untranslated (but marked for translation)
  
  string. "Home" is "Home" even after marking for translation, no need to pass
  it twice. Pass the context (so I18NC_NOOP can be used) and discard it.
  
  - Messages.sh covers all of kio, there's no Qt linguist file involved
  
  here.

TEST PLAN
  Builds, and the file places widget looks ok in Dolphin,
  both in English and in French (LC_ALL=fr_FR dolphin).

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24970

AFFECTED FILES
  CMakeLists.txt
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h
  src/filewidgets/kfileplacesmodel.cpp
  src/urifilters/ikws/kuriikwsfilter.cpp
  src/urifilters/ikws/kurisearchfilter.cpp

To: dfaure, aacid, ilic
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191026/66e40912/attachment.html>