<table><tr><td style="">dfaure created this revision.<br />dfaure added reviewers: aacid, ilic.<br />Herald added a project: Frameworks.<br />Herald added a subscriber: kde-frameworks-devel.<br />dfaure requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24970">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">Remove duplication of the untranslated (but marked for translation)</li>
</ul>
<p>string. "Home" is "Home" even after marking for translation, no need to pass<br />
it twice. Pass the context (so I18NC_NOOP can be used) and discard it.</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Messages.sh covers all of kio, there's no Qt linguist file involved</li>
</ul>
<p>here.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Builds, and the file places widget looks ok in Dolphin,<br />
both in English and in French (LC_ALL=fr_FR dolphin).</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24970">https://phabricator.kde.org/D24970</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />
src/filewidgets/kfileplacesitem.cpp<br />
src/filewidgets/kfileplacesitem_p.h<br />
src/filewidgets/kfileplacesmodel.cpp<br />
src/urifilters/ikws/kuriikwsfilter.cpp<br />
src/urifilters/ikws/kurisearchfilter.cpp</div></div></div><br /><div><strong>To: </strong>dfaure, aacid, ilic<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>