D22069: Localize long number strings

[Karl Ove Hufthammer]

huftis added a comment.


  In D22069#553328 <https://phabricator.kde.org/D22069#553328>, @flherne wrote:
  
  > I'm afraid this was a breaking API change -- it changes the behaviour, and not all numbers are intended to have separators added in this way.
  >
  > See https://bugs.kde.org/show_bug.cgi?id=413390
  
  
  The breaking API change happened earlier. This commit *fixed* it. Localised number formatting *used* to work on earlier versions of KDE (which is what KF5/Plasma/… was called then), but broke with the switch from KLocale to Qlocale.
  
  > A similar pattern occurs three different times just in KDevelop, and I can't even see how to work around this without breaking translations.
  
  For non-localised formatting of numbers, use QString::number() instead of QLocale::toString(), as detailed in https://api.kde.org/frameworks/ki18n/html/prg_guide.html#subs_notes. Note that this is not KDE-specific; it’s true for all Qt applications (KF5 just had a bug which made the user’s locale not being used).

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik, aacid
Cc: flherne, dfaure, aacid, huftis, safaalfulaij, mikeroyal, aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191024/04031d20/attachment.html>