<table><tr><td style="">huftis added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22069">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D22069#553328" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D22069#553328</a>, <a href="https://phabricator.kde.org/p/flherne/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@flherne</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>I'm afraid this was a breaking API change -- it changes the behaviour, and not all numbers are intended to have separators added in this way.</p>
<p>See <a href="https://bugs.kde.org/show_bug.cgi?id=413390" class="remarkup-link" target="_blank" rel="noreferrer">https://bugs.kde.org/show_bug.cgi?id=413390</a></p></div>
</blockquote>
<p>The breaking API change happened earlier. This commit *fixed* it. Localised number formatting *used* to work on earlier versions of KDE (which is what KF5/Plasma/… was called then), but broke with the switch from KLocale to Qlocale.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>A similar pattern occurs three different times just in KDevelop, and I can't even see how to work around this without breaking translations.</p></blockquote>
<p>For non-localised formatting of numbers, use QString::number() instead of QLocale::toString(), as detailed in <a href="https://api.kde.org/frameworks/ki18n/html/prg_guide.html#subs_notes" class="remarkup-link" target="_blank" rel="noreferrer">https://api.kde.org/frameworks/ki18n/html/prg_guide.html#subs_notes</a>. Note that this is not KDE-specific; it’s true for all Qt applications (KF5 just had a bug which made the user’s locale not being used).</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R249 KI18n</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22069">https://phabricator.kde.org/D22069</a></div></div><br /><div><strong>To: </strong>ngraham, Localization, Frameworks, broulik, aacid<br /><strong>Cc: </strong>flherne, dfaure, aacid, huftis, safaalfulaij, mikeroyal, aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>