D24873: [http kio slave] use QSslSocket instead of KTcpSocket (deprecated)

[Ahmad Samir]

ahmadsamir added a comment.


  In D24873#552795 <https://phabricator.kde.org/D24873#552795>, @vkrause wrote:
  
  > In D24873#552697 <https://phabricator.kde.org/D24873#552697>, @ahmadsamir wrote:
  >
  > > In D24873#552410 <https://phabricator.kde.org/D24873#552410>, @vkrause wrote:
  > >
  > > > This will compile, but it will only work correctly once TCPSlaveBase has been ported to QSslSocket too.
  > >
  > >
  > > If you say so.
  >
  >
  > Well, socket() returns the KTcpSocket that TCPSlaveBase created, so this cast will always return a nullptr.
  
  
  I wasn't doubting the validity of what you said, just I didn't see it, until now :)
  
  >> Anyway, I've started porting TcpSlaveBase. :)
  > 
  > Awesome! There seems to be only one other place that also assumes socket() returns a KTcpSocket (https://lxr.kde.org/source/kde/pim/kdepim-runtime/kioslave/pop3/pop3.cpp#0625).
  
  Yep.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24873

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191023/8638b847/attachment-0001.html>