D24873: [http kio slave] use QSslSocket instead of KTcpSocket (deprecated)
Volker Krause
noreply at phabricator.kde.org
Wed Oct 23 17:09:51 BST 2019
vkrause added a comment.
In D24873#552697 <https://phabricator.kde.org/D24873#552697>, @ahmadsamir wrote:
> In D24873#552410 <https://phabricator.kde.org/D24873#552410>, @vkrause wrote:
>
> > This will compile, but it will only work correctly once TCPSlaveBase has been ported to QSslSocket too.
>
>
> If you say so.
Well, socket() returns the KTcpSocket that TCPSlaveBase created, so this cast will always return a nullptr.
> Anyway, I've started porting TcpSlaveBase. :)
Awesome! There seems to be only one other place that also assumes socket() returns a KTcpSocket (https://lxr.kde.org/source/kde/pim/kdepim-runtime/kioslave/pop3/pop3.cpp#0625).
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24873
To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191023/22ab2a1d/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list