D21235: Add handling of fuseiso filesystem type

David Hallas noreply at phabricator.kde.org
Sat Oct 19 05:50:02 BST 2019


hallas added inline comments.

INLINE COMMENTS

> bruns wrote in fstabdevice.cpp:56
> fuseiso itself uses setmntent/addmntent/endmntent, so I see no reason getmntent should not work.
> Most importantly, the same implementation should be used for writing and reading.
> 
> https://sourceforge.net/p/fuseiso/code/HEAD/tree/trunk/src/fuseiso.c#l112

Yes i know :) But when I played around with the existing code in `fstabhandling.cpp` for reading out the fsname it kept being empty. But now I just wrote my own little test program that dumps every field in the `mntent` struct and there the fsname contains the full path to the iso file. So, I must have screwed up when fiddling with the `fstabhandling.cpp` code, let me give it another go, I think it would be much nicer to reuse that code then to have our own parser :)

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21235

To: hallas, bruns, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191019/971446d0/attachment.html>


More information about the Kde-frameworks-devel mailing list