D24695: Add a KF6 TODO to make KXMLGUIClient generic over a state enum
Méven Car
noreply at phabricator.kde.org
Wed Oct 16 17:43:22 BST 2019
meven added a comment.
In D24695#548248 <https://phabricator.kde.org/D24695#548248>, @dfaure wrote:
> In my experience 90 % of the users of this class don't care for the state feature, so I would rather move it to a separate class.
>
> Also this class is used everywhere, so the change would have massive repercussions, while most users (both subclasses and code using a kxmlguiclient pointer) don't care for the state thing.
>
> I suggest extracting the feature into a helper class separate from the kxmlguiclient hierarchy.
Great suggestion, I agree.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D24695
To: meven, #frameworks, kossebau, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191016/243e3866/attachment.html>
More information about the Kde-frameworks-devel
mailing list