D24466: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D24466#547084 <https://phabricator.kde.org/D24466#547084>, @dfaure wrote:
  
  > check_and_warn_compat does not warn for this testcase because the slot is deprecated too.
  >  Try a deprecated signal and a non-deprecated slot :-)
  >
  >   2714│     if (signal.attributes() & QMetaMethod::Compatibility) {
  >   2715│         if (!(method.attributes() & QMetaMethod::Compatibility))
  >   2716│             qWarning("QObject::connect: Connecting from COMPAT signal (%s::%s)",
  >   2717│                      sender->className(), signal.methodSignature().constData());
  
  
  Ah, missed that combination condition in the code. Though actually, I had tested all combinations before, disabling all or either of the QT_MOC_COMPAT (as you can see, blackbox testing without looking at the Qt code ;) ) , same with Q_DECL_DEPRECATED.  And then read that configure --release sets QT_NO_DEBUG, at which point I stopped looking more.

REPOSITORY
  R263 KXmlGui

BRANCH
  deprecatedapi

REVISION DETAIL
  https://phabricator.kde.org/D24466

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191014/fe6b70fd/attachment.html>