D24372: Compile without deprecated foreach
Ahmad Samir
noreply at phabricator.kde.org
Tue Oct 8 15:59:11 BST 2019
ahmadsamir updated this revision to Diff 67510.
ahmadsamir marked 7 inline comments as done.
ahmadsamir added a comment.
- User more descriptive var names other than list2
- qAsConst isn't needed if the method is const and the container is a member var
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24372?vs=67217&id=67510
BRANCH
ahmad/foreach-urifilters2 (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D24372
AFFECTED FILES
src/core/batchrenamejob.cpp
src/core/connection.cpp
src/core/copyjob.cpp
src/core/desktopexecparser.cpp
src/core/job.cpp
src/core/kprotocolinfofactory.cpp
src/core/kprotocolmanager.cpp
src/core/ksslcertificatemanager.cpp
src/core/ktcpsocket.cpp
src/core/scheduler.cpp
src/core/tcpslavebase.cpp
src/urifilters/ikws/ikwsopts.cpp
src/urifilters/ikws/searchproviderdlg.cpp
src/urifilters/shorturi/kshorturifilter.cpp
src/widgets/accessmanager.cpp
src/widgets/clipboardupdater.cpp
src/widgets/delegateanimationhandler.cpp
src/widgets/dropjob.cpp
src/widgets/kdesktopfileactions.cpp
src/widgets/kdirmodel.cpp
src/widgets/kfileitemactions.cpp
src/widgets/kfileitemdelegate.cpp
src/widgets/kpropertiesdialog.cpp
src/widgets/krun_win.cpp
src/widgets/ksslcertificatebox.cpp
src/widgets/ksslinfodialog.cpp
src/widgets/kurifiltersearchprovideractions.cpp
src/widgets/previewjob.cpp
src/widgets/sslui.cpp
To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191008/dd68e799/attachment.html>
More information about the Kde-frameworks-devel
mailing list