<table><tr><td style="">ahmadsamir updated this revision to Diff 67510.<br />ahmadsamir marked 7 inline comments as done.<br />ahmadsamir added a comment.

</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24372">View Revision</a></tr></table><br /><div><div><ul class="remarkup-list">

<li class="remarkup-list-item">User more descriptive var names other than list2</li>

<li class="remarkup-list-item">qAsConst isn't needed if the method is const and the container is a member var</li>

</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D24372?vs=67217&id=67510">https://phabricator.kde.org/D24372?vs=67217&id=67510</a></div></div><br /><div><strong>BRANCH</strong><div><div>ahmad/foreach-urifilters2 (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24372">https://phabricator.kde.org/D24372</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/core/batchrenamejob.cpp<br />

src/core/connection.cpp<br />

src/core/copyjob.cpp<br />

src/core/desktopexecparser.cpp<br />

src/core/job.cpp<br />

src/core/kprotocolinfofactory.cpp<br />

src/core/kprotocolmanager.cpp<br />

src/core/ksslcertificatemanager.cpp<br />

src/core/ktcpsocket.cpp<br />

src/core/scheduler.cpp<br />

src/core/tcpslavebase.cpp<br />

src/urifilters/ikws/ikwsopts.cpp<br />

src/urifilters/ikws/searchproviderdlg.cpp<br />

src/urifilters/shorturi/kshorturifilter.cpp<br />

src/widgets/accessmanager.cpp<br />

src/widgets/clipboardupdater.cpp<br />

src/widgets/delegateanimationhandler.cpp<br />

src/widgets/dropjob.cpp<br />

src/widgets/kdesktopfileactions.cpp<br />

src/widgets/kdirmodel.cpp<br />

src/widgets/kfileitemactions.cpp<br />

src/widgets/kfileitemdelegate.cpp<br />

src/widgets/kpropertiesdialog.cpp<br />

src/widgets/krun_win.cpp<br />

src/widgets/ksslcertificatebox.cpp<br />

src/widgets/ksslinfodialog.cpp<br />

src/widgets/kurifiltersearchprovideractions.cpp<br />

src/widgets/previewjob.cpp<br />

src/widgets/sslui.cpp</div></div></div><br /><div><strong>To: </strong>ahmadsamir, dfaure<br /><strong>Cc: </strong>kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns<br /></div>